Commit 50b3db3e authored by Alexey Simakov's avatar Alexey Simakov Committed by Jakub Kicinski
Browse files

broadcom: b44: prevent uninitialized value usage 



On execution path with raised B44_FLAG_EXTERNAL_PHY, b44_readphy()
leaves bmcr value uninitialized and it is used later in the code.

Add check of this flag at the beginning of the b44_nway_reset() and
exit early of the function with restarting autonegotiation if an
external PHY is used.

Fixes: 753f4920 ("[B44]: port to native ssb support")
Reviewed-by: default avatarJonas Gorski <jonas.gorski@gmail.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarAlexey Simakov <bigalex934@gmail.com>
Reviewed-by: default avatarMichael Chan <michael.chan@broadcom.com>
Link: https://patch.msgid.link/20251205155815.4348-1-bigalex934@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 6af2a01d

drivers/net/ethernet/broadcom/b44.c

+3 −0
Original line number Diff line number Diff line
@@ -1790,6 +1790,9 @@ static int b44_nway_reset(struct net_device *dev) 
	u32 bmcr;

	int r;



	if (bp->flags & B44_FLAG_EXTERNAL_PHY)

		return phy_ethtool_nway_reset(dev);



	spin_lock_irq(&bp->lock);

	b44_readphy(bp, MII_BMCR, &bmcr);

	b44_readphy(bp, MII_BMCR, &bmcr);