Commit 50b474e1 authored by Daniel Wagner's avatar Daniel Wagner Committed by Keith Busch
Browse files

nvmet-fc: remove null hostport pointer check 



An association has always a valid hostport pointer. Remove useless
null pointer check.

Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarDaniel Wagner <dwagner@suse.de>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
parent ca121a0f

drivers/nvme/target/fc.c

+2 −4
Original line number Diff line number Diff line
@@ -488,8 +488,7 @@ nvmet_fc_xmt_disconnect_assoc(struct nvmet_fc_tgt_assoc *assoc) 
	 * message is normal. Otherwise, send unless the hostport has

	 * already been invalidated by the lldd.

	 */

	if (!tgtport->ops->ls_req || !assoc->hostport ||

	    assoc->hostport->invalid)

	if (!tgtport->ops->ls_req || assoc->hostport->invalid)

		return;



	lsop = kzalloc((sizeof(*lsop) +
@@ -1524,8 +1523,7 @@ nvmet_fc_invalidate_host(struct nvmet_fc_target_port *target_port, 
	spin_lock_irqsave(&tgtport->lock, flags);

	list_for_each_entry_safe(assoc, next,

				&tgtport->assoc_list, a_list) {

		if (!assoc->hostport ||

		    assoc->hostport->hosthandle != hosthandle)

		if (assoc->hostport->hosthandle != hosthandle)

			continue;

		if (!nvmet_fc_tgt_a_get(assoc))

			continue;