Commit 50f8c419 authored by Kairui Song's avatar Kairui Song Committed by Andrew Morton
Browse files

mm, swap: remove redundant arguments and locking for enabling a device 

There is no need to repeatedly pass zero map and priority values.  zeromap
is similar to cluster info and swap_map, which are only used once the swap
device is exposed.  And the prio values are currently read only once set,
and only used for the list insertion upon expose or swap info display.

Link: https://lkml.kernel.org/r/20260218-swap-table-p3-v3-3-f4e34be021a7@tencent.com


Signed-off-by: default avatarKairui Song <kasong@tencent.com>
Acked-by: default avatarChris Li <chrisl@kernel.org>
Cc: Baoquan He <bhe@redhat.com>
Cc: Barry Song <baohua@kernel.org>
Cc: David Hildenbrand <david@kernel.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Kairui Song <ryncsn@gmail.com>
Cc: Kemeng Shi <shikemeng@huaweicloud.com>
Cc: kernel test robot <lkp@intel.com>
Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Cc: Nhat Pham <nphamcs@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 451c6326

mm/swapfile.c

+18 −30
Original line number Diff line number Diff line
@@ -2663,19 +2663,6 @@ static int setup_swap_extents(struct swap_info_struct *sis, 
	return generic_swapfile_activate(sis, swap_file, span);

}



static void setup_swap_info(struct swap_info_struct *si, int prio,

			    unsigned long *zeromap)

{

	si->prio = prio;

	/*

	 * the plist prio is negated because plist ordering is

	 * low-to-high, while swap ordering is high-to-low

	 */

	si->list.prio = -si->prio;

	si->avail_list.prio = -si->prio;

	si->zeromap = zeromap;

}



static void _enable_swap_info(struct swap_info_struct *si)

{

	atomic_long_add(si->pages, &nr_swap_pages);
@@ -2689,17 +2676,12 @@ static void _enable_swap_info(struct swap_info_struct *si) 
	add_to_avail_list(si, true);

}



static void enable_swap_info(struct swap_info_struct *si, int prio,

			     unsigned long *zeromap)

{

	spin_lock(&swap_lock);

	spin_lock(&si->lock);

	setup_swap_info(si, prio, zeromap);

	spin_unlock(&si->lock);

	spin_unlock(&swap_lock);

/*

	 * Finished initializing swap device, now it's safe to reference it.

 * Called after the swap device is ready, resurrect its percpu ref, it's now

 * safe to reference it. Add it to the list to expose it to the allocator.

 */

static void enable_swap_info(struct swap_info_struct *si)

{

	percpu_ref_resurrect(&si->users);

	spin_lock(&swap_lock);

	spin_lock(&si->lock);
@@ -2712,7 +2694,6 @@ static void reinsert_swap_info(struct swap_info_struct *si) 
{

	spin_lock(&swap_lock);

	spin_lock(&si->lock);

	setup_swap_info(si, si->prio, si->zeromap);

	_enable_swap_info(si);

	spin_unlock(&si->lock);

	spin_unlock(&swap_lock);
@@ -3356,7 +3337,6 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags) 
	int nr_extents;

	sector_t span;

	unsigned long maxpages;

	unsigned long *zeromap = NULL;

	struct folio *folio = NULL;

	struct inode *inode = NULL;

	bool inced_nr_rotate_swap = false;
@@ -3467,9 +3447,9 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags) 
	 * Use kvmalloc_array instead of bitmap_zalloc as the allocation order might

	 * be above MAX_PAGE_ORDER incase of a large swap file.

	 */

	zeromap = kvmalloc_array(BITS_TO_LONGS(maxpages), sizeof(long),

	si->zeromap = kvmalloc_array(BITS_TO_LONGS(maxpages), sizeof(long),

				     GFP_KERNEL | __GFP_ZERO);

	if (!zeromap) {

	if (!si->zeromap) {

		error = -ENOMEM;

		goto bad_swap_unlock_inode;

	}
@@ -3538,10 +3518,17 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags) 
	if (swap_flags & SWAP_FLAG_PREFER)

		prio = swap_flags & SWAP_FLAG_PRIO_MASK;



	/*

	 * The plist prio is negated because plist ordering is

	 * low-to-high, while swap ordering is high-to-low

	 */

	si->prio = prio;

	si->list.prio = -si->prio;

	si->avail_list.prio = -si->prio;

	si->swap_file = swap_file;



	/* Sets SWP_WRITEOK, resurrect the percpu ref, expose the swap device */

	enable_swap_info(si, prio, zeromap);

	enable_swap_info(si);



	pr_info("Adding %uk swap on %s.  Priority:%d extents:%d across:%lluk %s%s%s%s\n",

		K(si->pages), name->name, si->prio, nr_extents,
@@ -3571,6 +3558,8 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags) 
	si->swap_map = NULL;

	free_swap_cluster_info(si->cluster_info, si->max);

	si->cluster_info = NULL;

	kvfree(si->zeromap);

	si->zeromap = NULL;

	/*

	 * Clear the SWP_USED flag after all resources are freed so

	 * alloc_swap_info can reuse this si safely.
@@ -3578,7 +3567,6 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags) 
	spin_lock(&swap_lock);

	si->flags = 0;

	spin_unlock(&swap_lock);

	kvfree(zeromap);

	if (inced_nr_rotate_swap)

		atomic_dec(&nr_rotate_swap);

	if (swap_file)