Commit 514ca22a authored by Jocelyn Falempe's avatar Jocelyn Falempe Committed by Maarten Lankhorst
Browse files

drm/fb_dma: Add checks in drm_fb_dma_get_scanout_buffer() 



plane->state and plane->state->fb can be NULL, so add a check before
dereferencing them.
Found by testing with the imx driver.

Fixes: 879b3b65 ("drm/fb_dma: Add generic get_scanout_buffer() for drm_panic")
Signed-off-by: default avatarJocelyn Falempe <jfalempe@redhat.com>
Reviewed-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20240426121121.241366-1-jfalempe@redhat.com


(cherry picked from commit 986c12d8)
Signed-off-by: default avatarMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
parent 87cb4a61

drivers/gpu/drm/drm_fb_dma_helper.c

+3 −0
Original line number Diff line number Diff line
@@ -167,6 +167,9 @@ int drm_fb_dma_get_scanout_buffer(struct drm_plane *plane, 
	struct drm_gem_dma_object *dma_obj;

	struct drm_framebuffer *fb;



	if (!plane->state || !plane->state->fb)

		return -EINVAL;



	fb = plane->state->fb;

	/* Only support linear modifier */

	if (fb->modifier != DRM_FORMAT_MOD_LINEAR)