Unverified Commit 515f0897 authored by Karthik Poosa's avatar Karthik Poosa Committed by Rodrigo Vivi
Browse files

drm/xe/hwmon: Remove unwanted write permission for currN_label 



Change umode of currN_label from 0644 to 0444 as write permission
not needed for label.

Signed-off-by: default avatarKarthik Poosa <karthik.poosa@intel.com>
Reviewed-by: default avatarRiana Tauro <riana.tauro@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240419125945.4085629-1-karthik.poosa@intel.com


Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent 205e5c4b

drivers/gpu/drm/xe/xe_hwmon.c

+7 −2
Original line number Diff line number Diff line
@@ -550,12 +550,17 @@ xe_hwmon_curr_is_visible(const struct xe_hwmon *hwmon, u32 attr, int channel) 
{

	u32 uval;



	/* hwmon sysfs attribute of current available only for package */

	if (channel != CHANNEL_PKG)

		return 0;



	switch (attr) {

	case hwmon_curr_crit:

	case hwmon_curr_label:

		if (channel == CHANNEL_PKG)

			return (xe_hwmon_pcode_read_i1(hwmon->gt, &uval) ||

				(uval & POWER_SETUP_I1_WATTS)) ? 0 : 0644;

	case hwmon_curr_label:

			return (xe_hwmon_pcode_read_i1(hwmon->gt, &uval) ||

				(uval & POWER_SETUP_I1_WATTS)) ? 0 : 0444;

		break;

	default:

		return 0;