Unverified Commit 516f3664 authored by Niklas Cassel's avatar Niklas Cassel Committed by Krzysztof Wilczyński
Browse files

misc: pci_endpoint_test: Use a unique test pattern for each BAR 

Use a unique test pattern for each BAR in. This makes it easier to
detect/debug address translation issues, since a developer can dump
the backing memory on the EP side, using e.g. devmem, to verify that
the address translation for each BAR is actually correct.

Link: https://lore.kernel.org/linux-pci/20231215105952.1531683-1-nks@flawful.org


Signed-off-by: default avatarNiklas Cassel <niklas.cassel@wdc.com>
Signed-off-by: default avatarKrzysztof Wilczyński <kwilczynski@kernel.org>
Reviewed-by: default avatarDamien Le Moal <dlemoal@kernel.org>
Reviewed-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
parent 9ca65c37

drivers/misc/pci_endpoint_test.c

+12 −2
Original line number Diff line number Diff line
@@ -263,6 +263,15 @@ static bool pci_endpoint_test_request_irq(struct pci_endpoint_test *test) 
	return false;

}



static const u32 bar_test_pattern[] = {

	0xA0A0A0A0,

	0xA1A1A1A1,

	0xA2A2A2A2,

	0xA3A3A3A3,

	0xA4A4A4A4,

	0xA5A5A5A5,

};



static bool pci_endpoint_test_bar(struct pci_endpoint_test *test,

				  enum pci_barno barno)

{
@@ -280,11 +289,12 @@ static bool pci_endpoint_test_bar(struct pci_endpoint_test *test, 
		size = 0x4;



	for (j = 0; j < size; j += 4)

		pci_endpoint_test_bar_writel(test, barno, j, 0xA0A0A0A0);

		pci_endpoint_test_bar_writel(test, barno, j,

					     bar_test_pattern[barno]);



	for (j = 0; j < size; j += 4) {

		val = pci_endpoint_test_bar_readl(test, barno, j);

		if (val != 0xA0A0A0A0)

		if (val != bar_test_pattern[barno])

			return false;

	}