Commit 517b088a authored by Yonghong Song's avatar Yonghong Song Committed by Alexei Starovoitov
Browse files

selftests/bpf: Fix cgroup_mprog_ordering failure due to uninitialized variable 



On arm64, the cgroup_mprog_ordering selftest failed with test_progs run
when building with clang compiler. The reason is due to socklen_t optlen
not initialized.

In kernel function do_ip_getsockopt(), we have

        if (copy_from_sockptr(&len, optlen, sizeof(int)))
                return -EFAULT;
        if (len < 0)
                return -EINVAL;

The above 'len' variable is a negative value and hence the test failed.

But the test is okay on x86_64. I checked the x86_64 asm code and I didn't
see explicit initialization of 'optlen' but its value is 0 so kernel
didn't return error. This should be a pure luck.

Fix the bug by initializing 'oplen' var properly.

Fixes: e422d5f1 ("selftests/bpf: Add two selftests for mprog API based cgroup progs")
Signed-off-by: default avatarYonghong Song <yonghong.song@linux.dev>
Link: https://lore.kernel.org/r/20250611162103.1623692-1-yonghong.song@linux.dev


Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
parent c9b03a11

tools/testing/selftests/bpf/prog_tests/cgroup_mprog_ordering.c

+1 −1
Original line number Diff line number Diff line
@@ -12,7 +12,7 @@ static int run_getsockopt_test(int cg_parent, int sock_fd, bool has_relative_fd) 
	struct cgroup_preorder *skel = NULL;

	struct bpf_program *prog;

	__u8 *result, buf;

	socklen_t optlen;

	socklen_t optlen = 1;

	int err = 0;



	skel = cgroup_preorder__open_and_load();