Unverified Commit 51942b77 authored by Felix Gu's avatar Felix Gu Committed by Mark Brown
Browse files

spi: mtk-snfi: fix memory leak in probe 



ms->buf is allocated in mtk_snand_setup_pagefmt() but was not freed on
the following error paths.

Fixes: 2b1e1981 ("spi: mtk-snfi: Change default page format to setup default setting")
Signed-off-by: default avatarFelix Gu <ustc.gu@gmail.com>
Link: https://patch.msgid.link/20260416-mtk-snfi-v2-1-3f487689dacb@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 978df761

drivers/spi/spi-mtk-snfi.c

+5 −3
Original line number Diff line number Diff line
@@ -1447,14 +1447,14 @@ static int mtk_snand_probe(struct platform_device *pdev) 
	ret = nand_ecc_register_on_host_hw_engine(&ms->ecc_eng);

	if (ret) {

		dev_err(&pdev->dev, "failed to register ecc engine.\n");

		goto release_ecc;

		goto free_buf;

	}



	ret = devm_add_action_or_reset(&pdev->dev, mtk_unregister_ecc_engine,

				       &ms->ecc_eng);

	if (ret) {

		dev_err_probe(&pdev->dev, ret, "failed to add ECC unregister action\n");

		goto release_ecc;

		goto free_buf;

	}



	ctlr->num_chipselect = 1;
@@ -1465,10 +1465,12 @@ static int mtk_snand_probe(struct platform_device *pdev) 
	ret = spi_register_controller(ctlr);

	if (ret) {

		dev_err(&pdev->dev, "spi_register_controller failed.\n");

		goto release_ecc;

		goto free_buf;

	}



	return 0;

free_buf:

	kfree(ms->buf);

release_ecc:

	mtk_ecc_release(ms->ecc);

	return ret;