Commit 519b2b14 authored by Chenyuan Yang's avatar Chenyuan Yang Committed by Takashi Iwai
Browse files

ALSA: pcm: use new array-copying-wrapper 



This is found by our static analysis tool.

pcm_native.c utilizes memdup_user() to copy an array from userspace.

There is a new wrapper, specifically designed for copying arrays. Use
this one instead.

This is similar to the
commit 3e91a38d ("fbdev: viafb: use new array-copying-wrapper").

Signed-off-by: default avatarChenyuan Yang <chenyuan0y@gmail.com>
Link: https://patch.msgid.link/20250127160655.3119470-1-cy1yang@outlook.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent d85fc52c

sound/core/pcm_native.c

+1 −1
Original line number Diff line number Diff line
@@ -3245,7 +3245,7 @@ static int snd_pcm_xfern_frames_ioctl(struct snd_pcm_substream *substream, 
	if (copy_from_user(&xfern, _xfern, sizeof(xfern)))

		return -EFAULT;



	bufs = memdup_user(xfern.bufs, sizeof(void *) * runtime->channels);

	bufs = memdup_array_user(xfern.bufs, runtime->channels, sizeof(void *));

	if (IS_ERR(bufs))

		return PTR_ERR(bufs);

	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)