Unverified Commit 51e3eb3d authored by Sachin Mokashi's avatar Sachin Mokashi Committed by Mark Brown
Browse files

ASoC: Intel: ehl_rt5660: Use the correct rtd->dev device in hw_params 



In rt5660_hw_params(), the error path for snd_soc_dai_set_sysclk()
correctly uses rtd->dev as the logging device, but the error path for
snd_soc_dai_set_pll() uses codec_dai->dev instead.

These two devices are distinct:
- rtd->dev is the platform device of the PCM runtime (the Intel HDA/SSP
  controller, e.g. 0000:00:1f.3), which owns the machine driver callback.
- codec_dai->dev is the I2C device of the rt5660 codec itself
  (i2c-10EC5660:00).

Since hw_params is a machine driver operation and both calls are made
within the same function from the machine driver's context, all error
messages should be attributed to rtd->dev. Using codec_dai->dev for one
of them would suggest the error originates inside the codec driver,
which is misleading.

Align the PLL error log with the sysclk one to use rtd->dev, matching
the convention used by all other Intel board drivers in this directory.

Signed-off-by: default avatarSachin Mokashi <sachin.mokashi@intel.com>
Link: https://patch.msgid.link/20260327131439.1330373-1-sachin.mokashi@intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 62236375

sound/soc/intel/boards/ehl_rt5660.c

+1 −1
Original line number Diff line number Diff line
@@ -127,7 +127,7 @@ static int rt5660_hw_params(struct snd_pcm_substream *substream, 
				  params_rate(params) * 50,

				  params_rate(params) * 512);

	if (ret < 0)

		dev_err(codec_dai->dev, "can't set codec pll: %d\n", ret);

		dev_err(rtd->dev, "can't set codec pll: %d\n", ret);



	return ret;

}