Unverified Commit 51e8ce36 authored Jan 20, 2026 by Heikki Krogerus Committed by Andi Shyti Jan 22, 2026

i2c: designware: Remove an unnecessary condition



Writing also the high speed timing registers unconditionally.
The reset value for these registers is 0, so this should
always be safe.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/20260120130729.1679560-5-heikki.krogerus@linux.intel.com

parent cfbcc20d

drivers/i2c/busses/i2c-designware-common.c

+3 −5

Original line number	Diff line number	Diff line
		@@ -392,12 +392,10 @@ static void i2c_dw_write_timings(struct dw_i2c_dev *dev)
		regmap_write(dev->map, DW_IC_FS_SCL_HCNT, dev->fs_hcnt);
		regmap_write(dev->map, DW_IC_FS_SCL_LCNT, dev->fs_lcnt);

		/* Write high speed timing parameters if supported */
		if (dev->hs_hcnt && dev->hs_lcnt) {
		/* Write high speed timing parameters */
		regmap_write(dev->map, DW_IC_HS_SCL_HCNT, dev->hs_hcnt);
		regmap_write(dev->map, DW_IC_HS_SCL_LCNT, dev->hs_lcnt);
		}
		}

		/**
		* i2c_dw_set_mode() - Select the controller mode of operation - master or slave