Commit 51e9ea99 authored Oct 09, 2023 by Ian Rogers Committed by Namhyung Kim Oct 12, 2023

perf hists browser: Reorder variables to reduce padding



Address clang-tidy warning:
```
tools/perf/ui/browsers/hists.c:2416:8: warning: Excessive padding in 'struct popup_action' (8 padding bytes, where 0 is optimal).
Optimal fields order:
time,
thread,
evsel,
fn,
ms,
socket,
rstype,
```

Signed-off-by: Ian Rogers <irogers@google.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Yang Jihong <yangjihong1@huawei.com>
Cc: Huacai Chen <chenhuacai@kernel.org>
Cc: Nathan Chancellor <nathan@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: llvm@lists.linux.dev
Cc: Ming Wang <wangming01@loongson.cn>
Cc: Tom Rix <trix@redhat.com>
Cc: bpf@vger.kernel.org
Link: https://lore.kernel.org/r/20231009183920.200859-12-irogers@google.com


Signed-off-by: Namhyung Kim <namhyung@kernel.org>

parent 52a5ad12

tools/perf/ui/browsers/hists.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -2416,12 +2416,12 @@ static int switch_data_file(void)
		struct popup_action {
		unsigned long time;
		struct thread *thread;
		struct evsel *evsel;
		int (fn)(struct hist_browser browser, struct popup_action *act);
		struct map_symbol ms;
		int socket;
		struct evsel *evsel;
		enum rstype rstype;

		int (fn)(struct hist_browser browser, struct popup_action *act);
		};

		static int