Commit 51f0659f authored by Colin Ian King's avatar Colin Ian King Committed by Mikulas Patocka
Browse files

dm ioctl: rate limit a couple of ioctl based error messages 



It is possible to spam the kernel log with a misbehaving user process that
is passing incorrect dm ioctls to /dev/mapper/control. Use a rate limit
on these error messages to reduce the noise.

These errors were hit when running the stress-ng's device test.

Signed-off-by: default avatarColin Ian King <colin.i.king@gmail.com>
Acked-by: default avatarMike Snitzer <snitzer@kernel.org>
Signed-off-by: default avatarMikulas Patocka <mpatocka@redhat.com>
parent b0e6210e

drivers/md/dm-ioctl.c

+2 −2
Original line number Diff line number Diff line
@@ -1912,7 +1912,7 @@ static int check_version(unsigned int cmd, struct dm_ioctl __user *user, 


	if ((kernel_params->version[0] != DM_VERSION_MAJOR) ||

	    (kernel_params->version[1] > DM_VERSION_MINOR)) {

		DMERR("ioctl interface mismatch: kernel(%u.%u.%u), user(%u.%u.%u), cmd(%d)",

		DMERR_LIMIT("ioctl interface mismatch: kernel(%u.%u.%u), user(%u.%u.%u), cmd(%d)",

		      DM_VERSION_MAJOR, DM_VERSION_MINOR,

		      DM_VERSION_PATCHLEVEL,

		      kernel_params->version[0],
@@ -1961,7 +1961,7 @@ static int copy_params(struct dm_ioctl __user *user, struct dm_ioctl *param_kern 


	if (unlikely(param_kernel->data_size < minimum_data_size) ||

	    unlikely(param_kernel->data_size > DM_MAX_TARGETS * DM_MAX_TARGET_PARAMS)) {

		DMERR("Invalid data size in the ioctl structure: %u",

		DMERR_LIMIT("Invalid data size in the ioctl structure: %u",

		      param_kernel->data_size);

		return -EINVAL;

	}