Commit 5224f09a authored by Ingo Molnar's avatar Ingo Molnar
Browse files

x86/alternatives: Update comments in int3_emulate_push() 



The idtentry macro in entry_64.S hasn't had a create_gap
option for 5 years - update the comment.

(Also clean up the entire comment block while at it.)

Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Cc: Juergen Gross <jgross@suse.com>
Cc: "H . Peter Anvin" <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20250411054105.2341982-13-mingo@kernel.org
parent 762255b7

arch/x86/include/asm/text-patching.h

+5 −4
Original line number Diff line number Diff line
@@ -142,13 +142,14 @@ static __always_inline 
void int3_emulate_push(struct pt_regs *regs, unsigned long val)

{

	/*

	 * The int3 handler in entry_64.S adds a gap between the

	 * The INT3 handler in entry_64.S adds a gap between the

	 * stack where the break point happened, and the saving of

	 * pt_regs. We can extend the original stack because of

	 * this gap. See the idtentry macro's create_gap option.

	 * this gap. See the idtentry macro's X86_TRAP_BP logic.

	 *

	 * Similarly entry_32.S will have a gap on the stack for (any) hardware

	 * exception and pt_regs; see FIXUP_FRAME.

	 * Similarly, entry_32.S will have a gap on the stack for

	 * (any) hardware exception and pt_regs; see the

	 * FIXUP_FRAME macro.

	 */

	regs->sp -= sizeof(unsigned long);

	*(unsigned long *)regs->sp = val;