Commit 528876d8 authored by Joseph Huang's avatar Joseph Huang Committed by Jakub Kicinski
Browse files

net: dsa: mv88e6xxx: Fix out-of-bound access 



If an ATU violation was caused by a CPU Load operation, the SPID could
be larger than DSA_MAX_PORTS (the size of mv88e6xxx_chip.ports[] array).

Fixes: 75c05a74 ("net: dsa: mv88e6xxx: Fix counting of ATU violations")
Signed-off-by: default avatarJoseph Huang <Joseph.Huang@garmin.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20240819235251.1331763-1-Joseph.Huang@garmin.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 6efea513

drivers/net/dsa/mv88e6xxx/global1_atu.c

+2 −1
Original line number Diff line number Diff line
@@ -457,6 +457,7 @@ static irqreturn_t mv88e6xxx_g1_atu_prob_irq_thread_fn(int irq, void *dev_id) 
		trace_mv88e6xxx_atu_full_violation(chip->dev, spid,

						   entry.portvec, entry.mac,

						   fid);

		if (spid < ARRAY_SIZE(chip->ports))

			chip->ports[spid].atu_full_violation++;

	}