Commit 52966bf7 authored by Jeff Layton's avatar Jeff Layton Committed by Jakub Kicinski
Browse files

ref_tracker: use %p instead of %px in debugfs dentry name 



As Kees points out, this is a kernel address leak, and debugging is
not a sufficiently good reason to expose the real kernel address.

Fixes: 65b584f5 ("ref_tracker: automatically register a file in debugfs for a ref_tracker_dir")
Reported-by: default avatarKees Cook <kees@kernel.org>
Closes: https://lore.kernel.org/netdev/202507301603.62E553F93@keescook/


Signed-off-by: default avatarJeff Layton <jlayton@kernel.org>
Reviewed-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 61aaca8b

lib/ref_tracker.c

+1 −1
Original line number Diff line number Diff line
@@ -434,7 +434,7 @@ void ref_tracker_dir_debugfs(struct ref_tracker_dir *dir) 
	if (dentry && !xa_is_err(dentry))

		return;



	ret = snprintf(name, sizeof(name), "%s@%px", dir->class, dir);

	ret = snprintf(name, sizeof(name), "%s@%p", dir->class, dir);

	name[sizeof(name) - 1] = '\0';



	if (ret < sizeof(name)) {