Commit 5299b79c authored by Stefan Binding's avatar Stefan Binding Committed by Takashi Iwai
Browse files

ALSA: hda: cs35l41: Check mailbox status of pause command after firmware load 



Currently, we do not check the return status of the pause command,
immediately after we load firmware. If the pause has failed,
the firmware is not running.

Signed-off-by: default avatarStefan Binding <sbinding@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20230721151816.2080453-4-sbinding@opensource.cirrus.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent f8264c75

sound/pci/hda/cs35l41_hda.c

+6 −1
Original line number Diff line number Diff line
@@ -781,7 +781,12 @@ static int cs35l41_smart_amp(struct cs35l41_hda *cs35l41) 
		goto clean_dsp;

	}



	cs35l41_set_cspl_mbox_cmd(cs35l41->dev, cs35l41->regmap, CSPL_MBOX_CMD_PAUSE);

	ret = cs35l41_set_cspl_mbox_cmd(cs35l41->dev, cs35l41->regmap, CSPL_MBOX_CMD_PAUSE);

	if (ret) {

		dev_err(cs35l41->dev, "Error waiting for DSP to pause: %u\n", ret);

		goto clean_dsp;

	}



	cs35l41->firmware_running = true;



	return 0;