Commit 530694f5 authored by Samuel Zhang's avatar Samuel Zhang Committed by Mario Limonciello
Browse files

drm/amdgpu: do not resume device in thaw for normal hibernation 



For normal hibernation, GPU do not need to be resumed in thaw since it is
not involved in writing the hibernation image. Skip resume in this case
can reduce the hibernation time.

On VM with 8 * 192GB VRAM dGPUs, 98% VRAM usage and 1.7TB system memory,
this can save 50 minutes.

Signed-off-by: default avatarSamuel Zhang <guoqing.zhang@amd.com>
Tested-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Reviewed-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Reviewed-by: default avatarLijo Lazar <lijo.lazar@amd.com>
Link: https://lore.kernel.org/r/20250710062313.3226149-6-guoqing.zhang@amd.com


Signed-off-by: default avatarMario Limonciello <mario.limonciello@amd.com>
parent c2aaddbd

drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c

+17 −0
Original line number Diff line number Diff line
@@ -2541,6 +2541,10 @@ amdgpu_pci_shutdown(struct pci_dev *pdev) 
	if (amdgpu_ras_intr_triggered())

		return;



	/* device maybe not resumed here, return immediately in this case */

	if (adev->in_s4 && adev->in_suspend)

		return;



	/* if we are running in a VM, make sure the device

	 * torn down properly on reboot/shutdown.

	 * unfortunately we can't detect certain
@@ -2557,6 +2561,10 @@ static int amdgpu_pmops_prepare(struct device *dev) 
	struct drm_device *drm_dev = dev_get_drvdata(dev);

	struct amdgpu_device *adev = drm_to_adev(drm_dev);



	/* device maybe not resumed here, return immediately in this case */

	if (adev->in_s4 && adev->in_suspend)

		return 0;



	/* Return a positive number here so

	 * DPM_FLAG_SMART_SUSPEND works properly

	 */
@@ -2656,12 +2664,21 @@ static int amdgpu_pmops_thaw(struct device *dev) 
{

	struct drm_device *drm_dev = dev_get_drvdata(dev);



	/* do not resume device if it's normal hibernation */

	if (!pm_hibernate_is_recovering())

		return 0;



	return amdgpu_device_resume(drm_dev, true);

}



static int amdgpu_pmops_poweroff(struct device *dev)

{

	struct drm_device *drm_dev = dev_get_drvdata(dev);

	struct amdgpu_device *adev = drm_to_adev(drm_dev);



	/* device maybe not resumed here, return immediately in this case */

	if (adev->in_s4 && adev->in_suspend)

		return 0;



	return amdgpu_device_suspend(drm_dev, true);

}