Commit 5326ab73 authored by Maximilian Immanuel Brandtner's avatar Maximilian Immanuel Brandtner Committed by Michael S. Tsirkin
Browse files

virtio_console: fix order of fields cols and rows 



According to section 5.3.6.2 (Multiport Device Operation) of the virtio
spec(version 1.2) a control buffer with the event VIRTIO_CONSOLE_RESIZE
is followed by a virtio_console_resize struct containing cols then rows.
The kernel implements this the wrong way around (rows then cols) resulting
in the two values being swapped.

Signed-off-by: default avatarMaximilian Immanuel Brandtner <maxbr@linux.ibm.com>
Message-Id: <20250324144300.905535-1-maxbr@linux.ibm.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
parent fbd3039a

drivers/char/virtio_console.c

+1 −1
Original line number Diff line number Diff line
@@ -1576,8 +1576,8 @@ static void handle_control_message(struct virtio_device *vdev, 
		break;

	case VIRTIO_CONSOLE_RESIZE: {

		struct {

			__virtio16 rows;

			__virtio16 cols;

			__virtio16 rows;

		} size;



		if (!is_console_port(port))