Commit 53333cdf authored by Kohei Enju's avatar Kohei Enju Committed by Jaegeuk Kim
Browse files

f2fs: remove unnecessary null checking 



When __GFP_DIRECT_RECLAIM (included in both GFP_NOIO and GFP_KERNEL) is
specified, bio_alloc_bioset() never fails to allocate a bio.
Commit 67883ade ("f2fs: remove FAULT_ALLOC_BIO") replaced
f2fs_bio_alloc() with bio_alloc_bioset(), but null checking after
bio_alloc_bioset() was still left.

Fixes: 67883ade ("f2fs: remove FAULT_ALLOC_BIO")
Signed-off-by: default avatarKohei Enju <enjuk@amazon.com>
Reviewed-by: default avatarJens Axboe <axboe@kernel.dk>
Reviewed-by: default avatarChao Yu <chao@kernel.org>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
parent 21925ede

fs/f2fs/data.c

+0 −2
Original line number Diff line number Diff line
@@ -1041,8 +1041,6 @@ static struct bio *f2fs_grab_read_bio(struct inode *inode, block_t blkaddr, 
	bio = bio_alloc_bioset(bdev, bio_max_segs(nr_pages),

			       REQ_OP_READ | op_flag,

			       for_write ? GFP_NOIO : GFP_KERNEL, &f2fs_bioset);

	if (!bio)

		return ERR_PTR(-ENOMEM);

	bio->bi_iter.bi_sector = sector;

	f2fs_set_bio_crypt_ctx(bio, inode, first_idx, NULL, GFP_NOFS);

	bio->bi_end_io = f2fs_read_end_io;