Commit 53796b03 authored by Ismael Luceno's avatar Ismael Luceno Committed by Pablo Neira Ayuso
Browse files

ipvs: Avoid unnecessary calls to skb_is_gso_sctp 



In the context of the SCTP SNAT/DNAT handler, these calls can only
return true.

Fixes: e10d3ba4 ("ipvs: Fix checksumming on GSO of SCTP packets")
Signed-off-by: default avatarIsmael Luceno <iluceno@suse.de>
Acked-by: default avatarJulian Anastasov <ja@ssi.bg>
Acked-by: default avatarSimon Horman <horms@kernel.org>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent e169285f

net/netfilter/ipvs/ip_vs_proto_sctp.c

+2 −2
Original line number Diff line number Diff line
@@ -126,7 +126,7 @@ sctp_snat_handler(struct sk_buff *skb, struct ip_vs_protocol *pp, 
	if (sctph->source != cp->vport || payload_csum ||

	    skb->ip_summed == CHECKSUM_PARTIAL) {

		sctph->source = cp->vport;

		if (!skb_is_gso(skb) || !skb_is_gso_sctp(skb))

		if (!skb_is_gso(skb))

			sctp_nat_csum(skb, sctph, sctphoff);

	} else {

		skb->ip_summed = CHECKSUM_UNNECESSARY;
@@ -175,7 +175,7 @@ sctp_dnat_handler(struct sk_buff *skb, struct ip_vs_protocol *pp, 
	    (skb->ip_summed == CHECKSUM_PARTIAL &&

	     !(skb_dst(skb)->dev->features & NETIF_F_SCTP_CRC))) {

		sctph->dest = cp->dport;

		if (!skb_is_gso(skb) || !skb_is_gso_sctp(skb))

		if (!skb_is_gso(skb))

			sctp_nat_csum(skb, sctph, sctphoff);

	} else if (skb->ip_summed != CHECKSUM_PARTIAL) {

		skb->ip_summed = CHECKSUM_UNNECESSARY;