Commit 53b5ff83 authored by Piyush Mehta's avatar Piyush Mehta Committed by Greg Kroah-Hartman
Browse files

usb: dwc3: xilinx: improve error handling for PM APIs 



Improve error handling for PM APIs in the dwc3_xlnx_probe function by
introducing devm_pm_runtime_enable and error label. Removed unnecessary
API pm_runtime_disable call in dwc3_xlnx_remove.

Signed-off-by: default avatarPiyush Mehta <piyush.mehta@amd.com>
Signed-off-by: default avatarRadhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Link: https://lore.kernel.org/r/1700590878-124335-1-git-send-email-radhey.shyam.pandey@amd.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 51920207

drivers/usb/dwc3/dwc3-xilinx.c

+7 −4
Original line number Diff line number Diff line
@@ -293,11 +293,15 @@ static int dwc3_xlnx_probe(struct platform_device *pdev) 
		goto err_clk_put;



	pm_runtime_set_active(dev);

	pm_runtime_enable(dev);

	ret = devm_pm_runtime_enable(dev);

	if (ret < 0)

		goto err_pm_set_suspended;



	pm_suspend_ignore_children(dev, false);

	pm_runtime_get_sync(dev);

	return pm_runtime_resume_and_get(dev);



	return 0;

err_pm_set_suspended:

	pm_runtime_set_suspended(dev);



err_clk_put:

	clk_bulk_disable_unprepare(priv_data->num_clocks, priv_data->clks);
@@ -315,7 +319,6 @@ static void dwc3_xlnx_remove(struct platform_device *pdev) 
	clk_bulk_disable_unprepare(priv_data->num_clocks, priv_data->clks);

	priv_data->num_clocks = 0;



	pm_runtime_disable(dev);

	pm_runtime_put_noidle(dev);

	pm_runtime_set_suspended(dev);

}