Commit 53e3e5ba authored Apr 30, 2025 by Namjae Jeon Committed by Steve French May 01, 2025

ksmbd: prevent rename with empty string



Client can send empty newname string to ksmbd server.
It will cause a kernel oops from d_alloc.
This patch return the error when attempting to rename
a file or directory with an empty new name string.

Cc: stable@vger.kernel.org
Reported-by: Norbert Szetei <norbert@doyensec.com>
Tested-by: Norbert Szetei <norbert@doyensec.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>

parent ca91b950

fs/smb/server/smb2pdu.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -633,6 +633,11 @@ smb2_get_name(const char src, const int maxlen, struct nls_table local_nls)
		return name;
		}

		if (*name == '\0') {
		kfree(name);
		return ERR_PTR(-EINVAL);
		}

		if (*name == '\\') {
		pr_err("not allow directory name included leading slash\n");
		kfree(name);