Commit 53ec2101 authored by Dhananjay Ugwekar's avatar Dhananjay Ugwekar Committed by Mario Limonciello
Browse files

cpufreq/amd-pstate: Merge amd_pstate_epp_cpu_offline() and amd_pstate_epp_offline() 



amd_pstate_epp_offline() is only called from within
amd_pstate_epp_cpu_offline() and doesn't make much sense to have it at all.
Hence, remove it.

Also remove the unncessary debug print in the offline path while at it.

Signed-off-by: default avatarDhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>
Reviewed-by: default avatarGautham R. Shenoy <gautham.shenoy@amd.com>
Reviewed-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/20241204144842.164178-6-Dhananjay.Ugwekar@amd.com


Signed-off-by: default avatarMario Limonciello <mario.limonciello@amd.com>
parent b78f8c87

drivers/cpufreq/amd-pstate.c

+4 −13
Original line number Diff line number Diff line
@@ -1657,11 +1657,14 @@ static int amd_pstate_epp_cpu_online(struct cpufreq_policy *policy) 
	return 0;

}



static void amd_pstate_epp_offline(struct cpufreq_policy *policy)

static int amd_pstate_epp_cpu_offline(struct cpufreq_policy *policy)

{

	struct amd_cpudata *cpudata = policy->driver_data;

	int min_perf;



	if (cpudata->suspended)

		return 0;



	min_perf = READ_ONCE(cpudata->lowest_perf);



	mutex_lock(&amd_pstate_limits_lock);
@@ -1670,18 +1673,6 @@ static void amd_pstate_epp_offline(struct cpufreq_policy *policy) 
	amd_pstate_set_epp(cpudata, AMD_CPPC_EPP_BALANCE_POWERSAVE);



	mutex_unlock(&amd_pstate_limits_lock);

}



static int amd_pstate_epp_cpu_offline(struct cpufreq_policy *policy)

{

	struct amd_cpudata *cpudata = policy->driver_data;



	pr_debug("AMD CPU Core %d going offline\n", cpudata->cpu);



	if (cpudata->suspended)

		return 0;



	amd_pstate_epp_offline(policy);



	return 0;

}