Commit 54027869 authored by Ming Lei's avatar Ming Lei Committed by Jens Axboe
Browse files

block: remove blk_freeze_queue() 



No one use blk_freeze_queue(), so remove it and the obsolete comment.

Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarMing Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20241031133723.303835-2-ming.lei@redhat.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent f3d9bf05

block/blk-mq.c

+1 −21
Original line number Diff line number Diff line
@@ -161,31 +161,11 @@ int blk_mq_freeze_queue_wait_timeout(struct request_queue *q, 
}

EXPORT_SYMBOL_GPL(blk_mq_freeze_queue_wait_timeout);



/*

 * Guarantee no request is in use, so we can change any data structure of

 * the queue afterward.

 */

void blk_freeze_queue(struct request_queue *q)

void blk_mq_freeze_queue(struct request_queue *q)

{

	/*

	 * In the !blk_mq case we are only calling this to kill the

	 * q_usage_counter, otherwise this increases the freeze depth

	 * and waits for it to return to zero.  For this reason there is

	 * no blk_unfreeze_queue(), and blk_freeze_queue() is not

	 * exported to drivers as the only user for unfreeze is blk_mq.

	 */

	blk_freeze_queue_start(q);

	blk_mq_freeze_queue_wait(q);

}



void blk_mq_freeze_queue(struct request_queue *q)

{

	/*

	 * ...just an alias to keep freeze and unfreeze actions balanced

	 * in the blk_mq_* namespace

	 */

	blk_freeze_queue(q);

}

EXPORT_SYMBOL_GPL(blk_mq_freeze_queue);



bool __blk_mq_unfreeze_queue(struct request_queue *q, bool force_atomic)

block/blk.h

+0 −1
Original line number Diff line number Diff line
@@ -35,7 +35,6 @@ struct blk_flush_queue *blk_alloc_flush_queue(int node, int cmd_size, 
					      gfp_t flags);

void blk_free_flush_queue(struct blk_flush_queue *q);



void blk_freeze_queue(struct request_queue *q);

bool __blk_mq_unfreeze_queue(struct request_queue *q, bool force_atomic);

bool blk_queue_start_drain(struct request_queue *q);

bool __blk_freeze_queue_start(struct request_queue *q);