Commit 54091eee authored by Damien Le Moal's avatar Damien Le Moal Committed by Martin K. Petersen
Browse files

scsi: libsas: Refactor dev_is_sata() 



Use a switch statement in dev_is_sata() to make the code more readable
(and probably slightly better than a series of or conditions). Also have
this inline function return a boolean instead of an integer.

No functional changes.

Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
Link: https://lore.kernel.org/r/20250725015818.171252-2-dlemoal@kernel.org


Reviewed-by: default avatarJohn Garry <john.g.garry@oracle.com>
Reviewed-by: default avatarJason Yan <yanaijie@huawei.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 19272b37

include/scsi/sas_ata.h

+12 −5
Original line number Diff line number Diff line
@@ -15,10 +15,17 @@ 


#ifdef CONFIG_SCSI_SAS_ATA



static inline int dev_is_sata(struct domain_device *dev)

static inline bool dev_is_sata(struct domain_device *dev)

{

	return dev->dev_type == SAS_SATA_DEV || dev->dev_type == SAS_SATA_PM ||

	       dev->dev_type == SAS_SATA_PM_PORT || dev->dev_type == SAS_SATA_PENDING;

	switch (dev->dev_type) {

	case SAS_SATA_DEV:

	case SAS_SATA_PENDING:

	case SAS_SATA_PM:

	case SAS_SATA_PM_PORT:

		return true;

	default:

		return false;

	}

}



int sas_get_ata_info(struct domain_device *dev, struct ex_phy *phy);
@@ -49,9 +56,9 @@ static inline void sas_ata_disabled_notice(void) 
	pr_notice_once("ATA device seen but CONFIG_SCSI_SAS_ATA=N\n");

}



static inline int dev_is_sata(struct domain_device *dev)

static inline bool dev_is_sata(struct domain_device *dev)

{

	return 0;

	return false;

}

static inline int sas_ata_init(struct domain_device *dev)

{