Unverified Commit 542ede09 authored by Joanne Koong's avatar Joanne Koong Committed by Christian Brauner
Browse files

fuse: keep inode->i_blkbits constant 



With fuse now using iomap for writeback handling, inode blkbits changes
are problematic because iomap relies on inode->i_blkbits for its
internal bitmap logic. Currently we change inode->i_blkbits in fuse to
match the attr->blksize value passed in by the server.

This commit keeps inode->i_blkbits constant in fuse. Any attr->blksize
values passed in by the server will not update inode->i_blkbits. The
client-side behavior for stat is unaffected, stat will still reflect the
blocksize passed in by the server.

Signed-off-by: default avatarJoanne Koong <joannelkoong@gmail.com>
Link: https://lore.kernel.org/20250807175015.515192-1-joannelkoong@gmail.com


Fixes: ef7e7cbb ("fuse: use iomap for writeback")
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent bef2981b

fs/fuse/inode.c

+0 −5
Original line number Diff line number Diff line
@@ -289,11 +289,6 @@ void fuse_change_attributes_common(struct inode *inode, struct fuse_attr *attr, 
		}

	}



	if (attr->blksize != 0)

		inode->i_blkbits = ilog2(attr->blksize);

	else

		inode->i_blkbits = inode->i_sb->s_blocksize_bits;



	/*

	 * Don't set the sticky bit in i_mode, unless we want the VFS

	 * to check permissions.  This prevents failures due to the