Commit 543a5af3 authored by Jiri Slaby (SUSE)'s avatar Jiri Slaby (SUSE) Committed by Greg Kroah-Hartman
Browse files

serial: 8250: document doubled "type == PORT_8250_CIR" check 



The check for "port.type == PORT_8250_CIR" is present twice in
serial8250_register_8250_port(). The latter was already tried to be
dropped by 1104321a ("serial: Delete dead code for CIR serial
ports") and then reverted by 9527b82a ("Revert "serial: Delete dead
code for CIR serial ports"").

Document this weirdness with a reason.

Signed-off-by: default avatar"Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Suggested-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Link: https://lore.kernel.org/all/aFcDOx1bdB34I5hS@surfacebook.localdomain/


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20250624080641.509959-5-jirislaby@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2721fc7a

drivers/tty/serial/8250/8250_core.c

+2 −0
Original line number Diff line number Diff line
@@ -717,6 +717,7 @@ int serial8250_register_8250_port(const struct uart_8250_port *up) 
		nr_uarts++;

	}



	/* Check if it is CIR already. We check this below again, see there why. */

	if (uart->port.type == PORT_8250_CIR) {

		ret = -ENODEV;

		goto unlock;
@@ -815,6 +816,7 @@ int serial8250_register_8250_port(const struct uart_8250_port *up) 
	if (up->dl_write)

		uart->dl_write = up->dl_write;



	/* Check the type (again)! It might have changed by the port.type assignment above. */

	if (uart->port.type != PORT_8250_CIR) {

		if (uart_console_registered(&uart->port))

			pm_runtime_get_sync(uart->port.dev);