Commit 54b9460b authored by Dave Jiang's avatar Dave Jiang Committed by Dan Williams
Browse files

ACPI: HMAT: Remove register of memory node for generic target 



For generic targets, there's no reason to call
register_memory_node_under_compute_node() with the access levels that are
only visible to HMAT handling code. Only update the attributes and rename
hmat_register_generic_target_initiators() to hmat_update_generic_target().

The original call path ends up triggering register_memory_node_under_compute_node().
Although the access level would be "3" and not impact any current node arrays, it
introduces unwanted data into the numa node access_coordinate array.

Fixes: a3a3e341 ("acpi: numa: Add setting of generic port system locality attributes")
Cc: Rafael J. Wysocki <rafael@kernel.org>
Reviewed-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Tested-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarDave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/20240308220055.2172956-2-dave.jiang@intel.com


Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
parent d206a76d

drivers/acpi/numa/hmat.c

+4 −4
Original line number Diff line number Diff line
@@ -770,11 +770,11 @@ static void __hmat_register_target_initiators(struct memory_target *target, 
	}

}



static void hmat_register_generic_target_initiators(struct memory_target *target)

static void hmat_update_generic_target(struct memory_target *target)

{

	static DECLARE_BITMAP(p_nodes, MAX_NUMNODES);



	__hmat_register_target_initiators(target, p_nodes,

	hmat_update_target_attrs(target, p_nodes,

				 NODE_ACCESS_CLASS_GENPORT_SINK);

}
@@ -835,7 +835,7 @@ static void hmat_register_target(struct memory_target *target) 
	 */

	mutex_lock(&target_lock);

	if (*(u16 *)target->gen_port_device_handle) {

		hmat_register_generic_target_initiators(target);

		hmat_update_generic_target(target);

		target->registered = true;

	}

	mutex_unlock(&target_lock);