Unverified Commit 54fa71f5 authored by Johan Hovold's avatar Johan Hovold Committed by Mark Brown
Browse files

ASoC: codecs: pm4125: drop bogus container_of() error handling 



The dev_to_sdw_dev() helper uses container_of() to return the containing
soundwire device structure of its pointer argument and will never return
NULL.

Fixes: 8ad52948 ("ASoC: codecs: add new pm4125 audio codec driver")
Cc: Alexey Klimov <alexey.klimov@linaro.org>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Acked-by: default avatarAlexey Klimov <alexey.klimov@linaro.org>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://patch.msgid.link/20251219142715.19254-2-johan@kernel.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 56d953a8

sound/soc/codecs/pm4125.c

+0 −6
Original line number Diff line number Diff line
@@ -1537,13 +1537,7 @@ static int pm4125_bind(struct device *dev) 


	pm4125->sdw_priv[AIF1_CAP] = dev_get_drvdata(pm4125->txdev);

	pm4125->sdw_priv[AIF1_CAP]->pm4125 = pm4125;



	pm4125->tx_sdw_dev = dev_to_sdw_dev(pm4125->txdev);

	if (!pm4125->tx_sdw_dev) {

		dev_err(dev, "could not get txslave with matching of dev\n");

		ret = -EINVAL;

		goto error_put_tx;

	}



	/*

	 * As TX is the main CSR reg interface, which should not be suspended first.