Commit 550300b9 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Bartosz Golaszewski
Browse files

gpiolib: Remove redundant assignment of return variable 



In some functions the returned variable is assigned to 0 and then
reassigned to the actual value. Remove redundant assignments.

In one case make it more clear that the assignment is not needed.

Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20250416095645.2027695-9-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarBartosz Golaszewski <brgl@bgdev.pl>
parent 7cc86883

drivers/gpio/gpiolib.c

+6 −7
Original line number Diff line number Diff line
@@ -1015,7 +1015,7 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data, 
	struct gpio_device *gdev;

	unsigned int desc_index;

	int base = 0;

	int ret = 0;

	int ret;



	/* Only allow one set() and one set_multiple(). */

	if ((gc->set && gc->set_rv) ||
@@ -1040,11 +1040,10 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data, 


	device_set_node(&gdev->dev, gpiochip_choose_fwnode(gc));



	gdev->id = ida_alloc(&gpio_ida, GFP_KERNEL);

	if (gdev->id < 0) {

		ret = gdev->id;

	ret = ida_alloc(&gpio_ida, GFP_KERNEL);

	if (ret < 0)

		goto err_free_gdev;

	}

	gdev->id = ret;



	ret = dev_set_name(&gdev->dev, GPIOCHIP_NAME "%d", gdev->id);

	if (ret)
@@ -3068,7 +3067,7 @@ int gpiod_direction_output_nonotify(struct gpio_desc *desc, int value) 
 */

int gpiod_enable_hw_timestamp_ns(struct gpio_desc *desc, unsigned long flags)

{

	int ret = 0;

	int ret;



	VALIDATE_DESC(desc);
@@ -3101,7 +3100,7 @@ EXPORT_SYMBOL_GPL(gpiod_enable_hw_timestamp_ns); 
 */

int gpiod_disable_hw_timestamp_ns(struct gpio_desc *desc, unsigned long flags)

{

	int ret = 0;

	int ret;



	VALIDATE_DESC(desc);