Commit 55250b83 authored by Eric Dumazet's avatar Eric Dumazet Committed by Jakub Kicinski
Browse files

inet: reduce inet_csk_clone_lock() indent level 



Return early from inet_csk_clone_lock() if the socket
allocation failed, to reduce the indentation level.

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Reviewed-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
Link: https://patch.msgid.link/20250212131328.1514243-2-edumazet@google.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent a045e406

net/ipv4/inet_connection_sock.c

+27 −23
Original line number Diff line number Diff line
@@ -1237,9 +1237,12 @@ struct sock *inet_csk_clone_lock(const struct sock *sk, 
				 const gfp_t priority)

{

	struct sock *newsk = sk_clone_lock(sk, priority);

	struct inet_connection_sock *newicsk;



	if (newsk) {

		struct inet_connection_sock *newicsk = inet_csk(newsk);

	if (!newsk)

		return NULL;



	newicsk = inet_csk(newsk);



	inet_sk_set_state(newsk, TCP_SYN_RECV);

	newicsk->icsk_bind_hash = NULL;
@@ -1264,12 +1267,13 @@ struct sock *inet_csk_clone_lock(const struct sock *sk, 
	newicsk->icsk_probes_tstamp = 0;



	/* Deinitialize accept_queue to trap illegal accesses. */

		memset(&newicsk->icsk_accept_queue, 0, sizeof(newicsk->icsk_accept_queue));

	memset(&newicsk->icsk_accept_queue, 0,

	       sizeof(newicsk->icsk_accept_queue));



	inet_clone_ulp(req, newsk, priority);



	security_inet_csk_clone(newsk, req);

	}



	return newsk;

}

EXPORT_SYMBOL_GPL(inet_csk_clone_lock);