Commit 5555a307 authored by Jocelyn Falempe's avatar Jocelyn Falempe
Browse files

drm/panic: Rename draw_panic_static_* to draw_panic_screen_* 



I called them "static" because the panic screen is drawn only once,
but this can be confused with the static meaning in C.
Also remove some unnecessary braces in draw_panic_dispatch().
No functionnal change.

Reviewed-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Link: https://patch.msgid.link/20251216082524.115980-2-jfalempe@redhat.com


Signed-off-by: default avatarJocelyn Falempe <jfalempe@redhat.com>
parent a7c2f143

drivers/gpu/drm/drm_panic.c

+9 −9
Original line number Diff line number Diff line
@@ -476,7 +476,7 @@ static void drm_panic_logo_draw(struct drm_scanout_buffer *sb, struct drm_rect * 
				   fg_color);

}



static void draw_panic_static_user(struct drm_scanout_buffer *sb)

static void draw_panic_screen_user(struct drm_scanout_buffer *sb)

{

	u32 fg_color = drm_draw_color_from_xrgb8888(CONFIG_DRM_PANIC_FOREGROUND_COLOR,

						    sb->format->format);
@@ -545,7 +545,7 @@ static int draw_line_with_wrap(struct drm_scanout_buffer *sb, const struct font_ 
 * Draw the kmsg buffer to the screen, starting from the youngest message at the bottom,

 * and going up until reaching the top of the screen.

 */

static void draw_panic_static_kmsg(struct drm_scanout_buffer *sb)

static void draw_panic_screen_kmsg(struct drm_scanout_buffer *sb)

{

	u32 fg_color = drm_draw_color_from_xrgb8888(CONFIG_DRM_PANIC_FOREGROUND_COLOR,

						    sb->format->format);
@@ -733,7 +733,7 @@ static int drm_panic_get_qr_code(u8 **qr_image) 
/*

 * Draw the panic message at the center of the screen, with a QR Code

 */

static int _draw_panic_static_qr_code(struct drm_scanout_buffer *sb)

static int _draw_panic_screen_qr_code(struct drm_scanout_buffer *sb)

{

	u32 fg_color = drm_draw_color_from_xrgb8888(CONFIG_DRM_PANIC_FOREGROUND_COLOR,

						    sb->format->format);
@@ -801,10 +801,10 @@ static int _draw_panic_static_qr_code(struct drm_scanout_buffer *sb) 
	return 0;

}



static void draw_panic_static_qr_code(struct drm_scanout_buffer *sb)

static void draw_panic_screen_qr_code(struct drm_scanout_buffer *sb)

{

	if (_draw_panic_static_qr_code(sb))

		draw_panic_static_user(sb);

	if (_draw_panic_screen_qr_code(sb))

		draw_panic_screen_user(sb);

}

#else

static void drm_panic_qr_init(void) {};
@@ -879,18 +879,18 @@ static void draw_panic_dispatch(struct drm_scanout_buffer *sb) 
{

	switch (drm_panic_type) {

	case DRM_PANIC_TYPE_KMSG:

		draw_panic_static_kmsg(sb);

		draw_panic_screen_kmsg(sb);

		break;



#if IS_ENABLED(CONFIG_DRM_PANIC_SCREEN_QR_CODE)

	case DRM_PANIC_TYPE_QR:

		draw_panic_static_qr_code(sb);

		draw_panic_screen_qr_code(sb);

		break;

#endif



	case DRM_PANIC_TYPE_USER:

	default:

		draw_panic_static_user(sb);

		draw_panic_screen_user(sb);

	}

}