Commit 55a89d9c authored by Dan Williams's avatar Dan Williams Committed by Dave Jiang
Browse files

cxl/decoder: Drop pointless locking 



cxl_dpa_rwsem coordinates changes to dpa allocation settings for a given
decoder. cxl_decoder_reset() has no need for a consistent snapshot of the
dpa settings since it is merely clearing out whatever was there previously.

Otherwise, cxl_region_rwsem protects against 'reset' racing 'setup'.

In preparation for converting to rw_semaphore_acquire semantics, drop this
locking.

Cc: Davidlohr Bueso <dave@stgolabs.net>
Cc: Jonathan Cameron <jonathan.cameron@huawei.com>
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: Alison Schofield <alison.schofield@intel.com>
Cc: Vishal Verma <vishal.l.verma@intel.com>
Cc: Ira Weiny <ira.weiny@intel.com>
Acked-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: default avatarDave Jiang <dave.jiang@intel.com>
Reviewed-by: default avatarJonathan Cameron <jonathan.cameron@huawei.com>
Reviewed-by: default avatarAlison Schofield <alison.schofield@intel.com>
Reviewed-by: default avatarDavidlohr Bueso <dave@stgolabs.net>
Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
Link: https://patch.msgid.link/20250711234932.671292-5-dan.j.williams@intel.com


Signed-off-by: default avatarDave Jiang <dave.jiang@intel.com>
parent 7cb3b42a

drivers/cxl/core/hdm.c

+0 −2
Original line number Diff line number Diff line
@@ -914,7 +914,6 @@ static void cxl_decoder_reset(struct cxl_decoder *cxld) 
			"%s: out of order reset, expected decoder%d.%d\n",

			dev_name(&cxld->dev), port->id, port->commit_end);



	down_read(&cxl_dpa_rwsem);

	ctrl = readl(hdm + CXL_HDM_DECODER0_CTRL_OFFSET(id));

	ctrl &= ~CXL_HDM_DECODER0_CTRL_COMMIT;

	writel(ctrl, hdm + CXL_HDM_DECODER0_CTRL_OFFSET(id));
@@ -923,7 +922,6 @@ static void cxl_decoder_reset(struct cxl_decoder *cxld) 
	writel(0, hdm + CXL_HDM_DECODER0_SIZE_LOW_OFFSET(id));

	writel(0, hdm + CXL_HDM_DECODER0_BASE_HIGH_OFFSET(id));

	writel(0, hdm + CXL_HDM_DECODER0_BASE_LOW_OFFSET(id));

	up_read(&cxl_dpa_rwsem);



	cxld->flags &= ~CXL_DECODER_F_ENABLE;