Unverified Commit 55d4b698 authored by Rodrigo Vivi's avatar Rodrigo Vivi
Browse files

Revert "drm/xe/lnl: Enable GuC SLPC DCC task" 



This reverts commit 50554bf3.

DCC in LNL should be disabled. It was a mistake to decide
to go against GuC platform defaults in this case and this
could lead to regressions in some TDP limited scenarios
instead of helping.

Cc: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
Cc: Jonathan Cavitt <jonathan.cavitt@intel.com>
Reviewed-by: default avatarJonathan Cavitt <jonathan.cavitt@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250128223248.660748-1-rodrigo.vivi@intel.com


Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent 16016ade

drivers/gpu/drm/xe/xe_guc_pc.c

+0 −25
Original line number Diff line number Diff line
@@ -993,27 +993,6 @@ static int pc_init_freqs(struct xe_guc_pc *pc) 
	return ret;

}



static int slpc_enable_dcc(struct xe_guc_pc *pc)

{

	int ret;



	ret = pc_action_set_param(pc, SLPC_PARAM_TASK_ENABLE_DCC, 1);

	if (ret)

		return ret;



	return pc_action_set_param(pc, SLPC_PARAM_TASK_DISABLE_DCC, 0);

}



static int slpc_set_policies(struct xe_guc_pc *pc)

{

	struct xe_device *xe = pc_to_xe(pc);



	if (xe->info.platform == XE_LUNARLAKE)

		return slpc_enable_dcc(pc);



	return 0;

}



/**

 * xe_guc_pc_start - Start GuC's Power Conservation component

 * @pc: Xe_GuC_PC instance
@@ -1058,10 +1037,6 @@ int xe_guc_pc_start(struct xe_guc_pc *pc) 
		goto out;

	}



	ret = slpc_set_policies(pc);

	if (ret)

		goto out;



	ret = pc_init_freqs(pc);

	if (ret)

		goto out;