Commit 55dc632a authored by Ian Ray's avatar Ian Ray Committed by Jakub Kicinski
Browse files

NFC: nxp-nci: allow GPIOs to sleep 



Allow the firmware and enable GPIOs to sleep.

This fixes a `WARN_ON' and allows the driver to operate GPIOs which are
connected to I2C GPIO expanders.

-- >8 --
kernel: WARNING: CPU: 3 PID: 2636 at drivers/gpio/gpiolib.c:3880 gpiod_set_value+0x88/0x98
-- >8 --

Fixes: 43201767 ("NFC: nxp-nci: Convert to use GPIO descriptor")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarIan Ray <ian.ray@gehealthcare.com>
Link: https://patch.msgid.link/20260317085337.146545-1-ian.ray@gehealthcare.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 34b11cc5

drivers/nfc/nxp-nci/i2c.c

+2 −2
Original line number Diff line number Diff line
@@ -47,8 +47,8 @@ static int nxp_nci_i2c_set_mode(void *phy_id, 
{

	struct nxp_nci_i2c_phy *phy = (struct nxp_nci_i2c_phy *) phy_id;



	gpiod_set_value(phy->gpiod_fw, (mode == NXP_NCI_MODE_FW) ? 1 : 0);

	gpiod_set_value(phy->gpiod_en, (mode != NXP_NCI_MODE_COLD) ? 1 : 0);

	gpiod_set_value_cansleep(phy->gpiod_fw, (mode == NXP_NCI_MODE_FW) ? 1 : 0);

	gpiod_set_value_cansleep(phy->gpiod_en, (mode != NXP_NCI_MODE_COLD) ? 1 : 0);

	usleep_range(10000, 15000);



	if (mode == NXP_NCI_MODE_COLD)