Commit 55faeb89 authored by Russell King (Oracle)'s avatar Russell King (Oracle) Committed by Jakub Kicinski
Browse files

net: xpcs: remove xpcs_config_eee() from global scope 



Make xpcs_config_eee() private to the XPCS driver, called only from
the phylink pcs_disable_eee() and pcs_enable_eee() methods.

Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1thRQT-003w7O-Ec@rmk-PC.armlinux.org.uk


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent dba7441b

drivers/net/pcs/pcs-xpcs.c

+4 −10
Original line number Diff line number Diff line
@@ -602,7 +602,7 @@ static void xpcs_get_interfaces(struct dw_xpcs *xpcs, unsigned long *interfaces) 
		__set_bit(compat->interface, interfaces);

}



static int __xpcs_config_eee(struct dw_xpcs *xpcs, int mult_fact_100ns,

static int xpcs_config_eee(struct dw_xpcs *xpcs, int mult_fact_100ns,

			   int enable)

{

	u16 mask, val;
@@ -632,12 +632,6 @@ static int __xpcs_config_eee(struct dw_xpcs *xpcs, int mult_fact_100ns, 
			   enable ? DW_VR_MII_EEE_TRN_LPI : 0);

}



int xpcs_config_eee(struct dw_xpcs *xpcs, int mult_fact_100ns, int enable)

{

	return 0;

}

EXPORT_SYMBOL_GPL(xpcs_config_eee);



static void xpcs_pre_config(struct phylink_pcs *pcs, phy_interface_t interface)

{

	struct dw_xpcs *xpcs = phylink_pcs_to_xpcs(pcs);
@@ -1203,14 +1197,14 @@ static void xpcs_disable_eee(struct phylink_pcs *pcs) 
{

	struct dw_xpcs *xpcs = phylink_pcs_to_xpcs(pcs);



	__xpcs_config_eee(xpcs, 0, false);

	xpcs_config_eee(xpcs, 0, false);

}



static void xpcs_enable_eee(struct phylink_pcs *pcs)

{

	struct dw_xpcs *xpcs = phylink_pcs_to_xpcs(pcs);



	__xpcs_config_eee(xpcs, xpcs->eee_mult_fact, true);

	xpcs_config_eee(xpcs, xpcs->eee_mult_fact, true);

}



/**

include/linux/pcs/pcs-xpcs.h

+0 −2
Original line number Diff line number Diff line
@@ -50,8 +50,6 @@ struct dw_xpcs; 


struct phylink_pcs *xpcs_to_phylink_pcs(struct dw_xpcs *xpcs);

int xpcs_get_an_mode(struct dw_xpcs *xpcs, phy_interface_t interface);

int xpcs_config_eee(struct dw_xpcs *xpcs, int mult_fact_100ns,

		    int enable);

void xpcs_config_eee_mult_fact(struct dw_xpcs *xpcs, u8 mult_fact);

struct dw_xpcs *xpcs_create_mdiodev(struct mii_bus *bus, int addr);

struct dw_xpcs *xpcs_create_fwnode(struct fwnode_handle *fwnode);