Commit 561e3a0c authored by Al Viro's avatar Al Viro Committed by Jens Axboe
Browse files

io_uring/fdinfo: fix io_uring_show_fdinfo() misuse of ->d_iname 



Output of io_uring_show_fdinfo() has several problems:

* racy use of ->d_iname
* junk if the name is long - in that case it's not stored in ->d_iname
at all
* lack of quoting (names can contain newlines, etc. - or be equal to "<none>",
for that matter).
* lines for empty slots are pointless noise - we already have the total
amount, so having just the non-empty ones would carry the same information.

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent bab4b2cc

io_uring/fdinfo.c

+5 −4
Original line number Diff line number Diff line
@@ -211,10 +211,11 @@ __cold void io_uring_show_fdinfo(struct seq_file *m, struct file *file) 


		if (ctx->file_table.data.nodes[i])

			f = io_slot_file(ctx->file_table.data.nodes[i]);

		if (f)

			seq_printf(m, "%5u: %s\n", i, file_dentry(f)->d_iname);

		else

			seq_printf(m, "%5u: <none>\n", i);

		if (f) {

			seq_printf(m, "%5u: ", i);

			seq_file_path(m, f, " \t\n\\");

			seq_puts(m, "\n");

		}

	}

	seq_printf(m, "UserBufs:\t%u\n", ctx->buf_table.nr);

	for (i = 0; has_lock && i < ctx->buf_table.nr; i++) {