Commit 5625ca56 authored by Mateusz Polchlopek's avatar Mateusz Polchlopek Committed by Tony Nguyen
Browse files

devlink: extend devlink_param *set pointer 



Extend devlink_param *set function pointer to take extack as a param.
Sometimes it is needed to pass information to the end user from set
function. It is more proper to use for that netlink instead of passing
message to dmesg.

Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
Reviewed-by: default avatarPrzemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: default avatarMateusz Polchlopek <mateusz.polchlopek@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent c51db4ac

drivers/crypto/marvell/octeontx2/otx2_cpt_devlink.c

+6 −3
Original line number Diff line number Diff line
@@ -4,7 +4,8 @@ 
#include "otx2_cpt_devlink.h"



static int otx2_cpt_dl_egrp_create(struct devlink *dl, u32 id,

				   struct devlink_param_gset_ctx *ctx)

				   struct devlink_param_gset_ctx *ctx,

				   struct netlink_ext_ack *extack)

{

	struct otx2_cpt_devlink *cpt_dl = devlink_priv(dl);

	struct otx2_cptpf_dev *cptpf = cpt_dl->cptpf;
@@ -13,7 +14,8 @@ static int otx2_cpt_dl_egrp_create(struct devlink *dl, u32 id, 
}



static int otx2_cpt_dl_egrp_delete(struct devlink *dl, u32 id,

				   struct devlink_param_gset_ctx *ctx)

				   struct devlink_param_gset_ctx *ctx,

				   struct netlink_ext_ack *extack)

{

	struct otx2_cpt_devlink *cpt_dl = devlink_priv(dl);

	struct otx2_cptpf_dev *cptpf = cpt_dl->cptpf;
@@ -45,7 +47,8 @@ static int otx2_cpt_dl_t106_mode_get(struct devlink *dl, u32 id, 
}



static int otx2_cpt_dl_t106_mode_set(struct devlink *dl, u32 id,

				     struct devlink_param_gset_ctx *ctx)

				     struct devlink_param_gset_ctx *ctx,

				     struct netlink_ext_ack *extack)

{

	struct otx2_cpt_devlink *cpt_dl = devlink_priv(dl);

	struct otx2_cptpf_dev *cptpf = cpt_dl->cptpf;

drivers/net/ethernet/amd/pds_core/core.h

+2 −1
Original line number Diff line number Diff line
@@ -256,7 +256,8 @@ int pdsc_dl_flash_update(struct devlink *dl, 
int pdsc_dl_enable_get(struct devlink *dl, u32 id,

		       struct devlink_param_gset_ctx *ctx);

int pdsc_dl_enable_set(struct devlink *dl, u32 id,

		       struct devlink_param_gset_ctx *ctx);

		       struct devlink_param_gset_ctx *ctx,

		       struct netlink_ext_ack *extack);

int pdsc_dl_enable_validate(struct devlink *dl, u32 id,

			    union devlink_param_value val,

			    struct netlink_ext_ack *extack);

drivers/net/ethernet/amd/pds_core/devlink.c

+2 −1
Original line number Diff line number Diff line
@@ -37,7 +37,8 @@ int pdsc_dl_enable_get(struct devlink *dl, u32 id, 
}



int pdsc_dl_enable_set(struct devlink *dl, u32 id,

		       struct devlink_param_gset_ctx *ctx)

		       struct devlink_param_gset_ctx *ctx,

		       struct netlink_ext_ack *extack)

{

	struct pdsc *pdsc = devlink_priv(dl);

	struct pdsc_viftype *vt_entry;

drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c

+4 −2
Original line number Diff line number Diff line
@@ -1096,7 +1096,8 @@ static int bnxt_dl_nvm_param_get(struct devlink *dl, u32 id, 
}



static int bnxt_dl_nvm_param_set(struct devlink *dl, u32 id,

				 struct devlink_param_gset_ctx *ctx)

				 struct devlink_param_gset_ctx *ctx,

				 struct netlink_ext_ack *extack)

{

	struct bnxt *bp = bnxt_get_bp_from_dl(dl);

	struct hwrm_nvm_set_variable_input *req;
@@ -1145,7 +1146,8 @@ static int bnxt_remote_dev_reset_get(struct devlink *dl, u32 id, 
}



static int bnxt_remote_dev_reset_set(struct devlink *dl, u32 id,

				     struct devlink_param_gset_ctx *ctx)

				     struct devlink_param_gset_ctx *ctx,

				     struct netlink_ext_ack *extack)

{

	struct bnxt *bp = bnxt_get_bp_from_dl(dl);

	int rc;

drivers/net/ethernet/intel/ice/devlink/devlink.c

+6 −6
Original line number Diff line number Diff line
@@ -1144,9 +1144,9 @@ ice_devlink_enable_roce_get(struct devlink *devlink, u32 id, 
	return 0;

}



static int

ice_devlink_enable_roce_set(struct devlink *devlink, u32 id,

			    struct devlink_param_gset_ctx *ctx)

static int ice_devlink_enable_roce_set(struct devlink *devlink, u32 id,

				       struct devlink_param_gset_ctx *ctx,

				       struct netlink_ext_ack *extack)

{

	struct ice_pf *pf = devlink_priv(devlink);

	bool roce_ena = ctx->val.vbool;
@@ -1195,9 +1195,9 @@ ice_devlink_enable_iw_get(struct devlink *devlink, u32 id, 
	return 0;

}



static int

ice_devlink_enable_iw_set(struct devlink *devlink, u32 id,

			  struct devlink_param_gset_ctx *ctx)

static int ice_devlink_enable_iw_set(struct devlink *devlink, u32 id,

				     struct devlink_param_gset_ctx *ctx,

				     struct netlink_ext_ack *extack)

{

	struct ice_pf *pf = devlink_priv(devlink);

	bool iw_ena = ctx->val.vbool;