Commit 56534636 authored by Shrikanth Hegde's avatar Shrikanth Hegde Committed by Madhavan Srinivasan
Browse files

powerpc: fadump: use lock guard for mutex 

use scoped_guard for scope based resource management of mutex.
This would make the code simpler and easier to maintain.

More details on lock guards can be found at
https://lore.kernel.org/all/20230612093537.614161713@infradead.org/T/#u



Reviewed-by: default avatarSrikar Dronamraju <srikar@linux.ibm.com>
Signed-off-by: default avatarShrikanth Hegde <sshegde@linux.ibm.com>
Tested-by: default avatarVenkat Rao Bagalkote <venkat88@linux.ibm.com>
Reviewed-by: default avatarSourabh Jain <sourabhjain@linux.ibm.com>
Signed-off-by: default avatarMadhavan Srinivasan <maddy@linux.ibm.com>
Link: https://patch.msgid.link/20250505075333.184463-4-sshegde@linux.ibm.com
parent 6a21d3c5

arch/powerpc/kernel/fadump.c

+4 −7
Original line number Diff line number Diff line
@@ -1373,14 +1373,11 @@ static void fadump_free_elfcorehdr_buf(void) 


static void fadump_invalidate_release_mem(void)

{

	mutex_lock(&fadump_mutex);

	if (!fw_dump.dump_active) {

		mutex_unlock(&fadump_mutex);

	scoped_guard(mutex, &fadump_mutex) {

		if (!fw_dump.dump_active)

			return;

	}



		fadump_cleanup();

	mutex_unlock(&fadump_mutex);

	}



	fadump_free_elfcorehdr_buf();

	fadump_release_memory(fw_dump.boot_mem_top, memblock_end_of_DRAM());