Commit 569c392e authored by Dr. David Alan Gilbert's avatar Dr. David Alan Gilbert Committed by Michael S. Tsirkin
Browse files

vhost: vringh: Remove unused iotlb functions 



The functions:
  vringh_abandon_iotlb()
  vringh_notify_disable_iotlb() and
  vringh_notify_enable_iotlb()

were added in 2020 by
commit 9ad9c49c ("vringh: IOTLB support")
but have remained unused.

Remove them.

Signed-off-by: default avatarDr. David Alan Gilbert <linux@treblig.org>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Message-Id: <20250617001838.114457-2-linux@treblig.org>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Acked-by: default avatarEugenio Pérez <eperezma@redhat.com>
Tested-by: default avatarLei Yang <leiyang@redhat.com>
parent 69cd720a

drivers/vhost/vringh.c

+0 −43
Original line number Diff line number Diff line
@@ -1534,23 +1534,6 @@ ssize_t vringh_iov_push_iotlb(struct vringh *vrh, 
}

EXPORT_SYMBOL(vringh_iov_push_iotlb);



/**

 * vringh_abandon_iotlb - we've decided not to handle the descriptor(s).

 * @vrh: the vring.

 * @num: the number of descriptors to put back (ie. num

 *	 vringh_get_iotlb() to undo).

 *

 * The next vringh_get_iotlb() will return the old descriptor(s) again.

 */

void vringh_abandon_iotlb(struct vringh *vrh, unsigned int num)

{

	/* We only update vring_avail_event(vr) when we want to be notified,

	 * so we haven't changed that yet.

	 */

	vrh->last_avail_idx -= num;

}

EXPORT_SYMBOL(vringh_abandon_iotlb);



/**

 * vringh_complete_iotlb - we've finished with descriptor, publish it.

 * @vrh: the vring.
@@ -1571,32 +1554,6 @@ int vringh_complete_iotlb(struct vringh *vrh, u16 head, u32 len) 
}

EXPORT_SYMBOL(vringh_complete_iotlb);



/**

 * vringh_notify_enable_iotlb - we want to know if something changes.

 * @vrh: the vring.

 *

 * This always enables notifications, but returns false if there are

 * now more buffers available in the vring.

 */

bool vringh_notify_enable_iotlb(struct vringh *vrh)

{

	return __vringh_notify_enable(vrh, getu16_iotlb, putu16_iotlb);

}

EXPORT_SYMBOL(vringh_notify_enable_iotlb);



/**

 * vringh_notify_disable_iotlb - don't tell us if something changes.

 * @vrh: the vring.

 *

 * This is our normal running state: we disable and then only enable when

 * we're going to sleep.

 */

void vringh_notify_disable_iotlb(struct vringh *vrh)

{

	__vringh_notify_disable(vrh, putu16_iotlb);

}

EXPORT_SYMBOL(vringh_notify_disable_iotlb);



/**

 * vringh_need_notify_iotlb - must we tell the other side about used buffers?

 * @vrh: the vring we've called vringh_complete_iotlb() on.

include/linux/vringh.h

+0 −5
Original line number Diff line number Diff line
@@ -319,13 +319,8 @@ ssize_t vringh_iov_push_iotlb(struct vringh *vrh, 
			      struct vringh_kiov *wiov,

			      const void *src, size_t len);



void vringh_abandon_iotlb(struct vringh *vrh, unsigned int num);



int vringh_complete_iotlb(struct vringh *vrh, u16 head, u32 len);



bool vringh_notify_enable_iotlb(struct vringh *vrh);

void vringh_notify_disable_iotlb(struct vringh *vrh);



int vringh_need_notify_iotlb(struct vringh *vrh);



#endif /* CONFIG_VHOST_IOTLB */