Commit 56bcc6ec authored by Lee Trager's avatar Lee Trager Committed by Jakub Kicinski
Browse files

eth: fbnic: Prepend TSENE FW fields with FBNIC_FW 



All other firmware fields are prepended with FBNIC_FW. Update TSENE fields
to follow the same format.

Signed-off-by: default avatarLee Trager <lee@trager.us>
Link: https://patch.msgid.link/20250228191935.3953712-2-lee@trager.us


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 35df5eb9

drivers/net/ethernet/meta/fbnic/fbnic_fw.c

+8 −8
Original line number Diff line number Diff line
@@ -743,9 +743,9 @@ int fbnic_fw_xmit_tsene_read_msg(struct fbnic_dev *fbd, 
}



static const struct fbnic_tlv_index fbnic_tsene_read_resp_index[] = {

	FBNIC_TLV_ATTR_S32(FBNIC_TSENE_THERM),

	FBNIC_TLV_ATTR_S32(FBNIC_TSENE_VOLT),

	FBNIC_TLV_ATTR_S32(FBNIC_TSENE_ERROR),

	FBNIC_TLV_ATTR_S32(FBNIC_FW_TSENE_THERM),

	FBNIC_TLV_ATTR_S32(FBNIC_FW_TSENE_VOLT),

	FBNIC_TLV_ATTR_S32(FBNIC_FW_TSENE_ERROR),

	FBNIC_TLV_ATTR_LAST

};
@@ -762,21 +762,21 @@ static int fbnic_fw_parse_tsene_read_resp(void *opaque, 
	if (!cmpl_data)

		return -EINVAL;



	if (results[FBNIC_TSENE_ERROR]) {

		err = fbnic_tlv_attr_get_unsigned(results[FBNIC_TSENE_ERROR]);

	if (results[FBNIC_FW_TSENE_ERROR]) {

		err = fbnic_tlv_attr_get_unsigned(results[FBNIC_FW_TSENE_ERROR]);

		if (err)

			goto exit_complete;

	}



	if (!results[FBNIC_TSENE_THERM] || !results[FBNIC_TSENE_VOLT]) {

	if (!results[FBNIC_FW_TSENE_THERM] || !results[FBNIC_FW_TSENE_VOLT]) {

		err = -EINVAL;

		goto exit_complete;

	}



	cmpl_data->u.tsene.millidegrees =

		fbnic_tlv_attr_get_signed(results[FBNIC_TSENE_THERM]);

		fbnic_tlv_attr_get_signed(results[FBNIC_FW_TSENE_THERM]);

	cmpl_data->u.tsene.millivolts =

		fbnic_tlv_attr_get_signed(results[FBNIC_TSENE_VOLT]);

		fbnic_tlv_attr_get_signed(results[FBNIC_FW_TSENE_VOLT]);



exit_complete:

	cmpl_data->result = err;

drivers/net/ethernet/meta/fbnic/fbnic_fw.h

+4 −4
Original line number Diff line number Diff line
@@ -139,10 +139,10 @@ enum { 
};



enum {

	FBNIC_TSENE_THERM			= 0x0,

	FBNIC_TSENE_VOLT			= 0x1,

	FBNIC_TSENE_ERROR			= 0x2,

	FBNIC_TSENE_MSG_MAX

	FBNIC_FW_TSENE_THERM			= 0x0,

	FBNIC_FW_TSENE_VOLT			= 0x1,

	FBNIC_FW_TSENE_ERROR			= 0x2,

	FBNIC_FW_TSENE_MSG_MAX

};



enum {