Commit 56e1f53b authored by Hans de Goede's avatar Hans de Goede
Browse files

platform/x86: x86-android-tablets: Remove invalid_aei_gpiochip support 



x86_dev_info.invalid_aei_gpiochip is no longer used by any boards
and the x86-android-tablets code should not use the gpiolib private
acpi_gpiochip_free_interrupts() function.

Reported-by: default avatarBartosz Golaszewski <brgl@bgdev.pl>
Closes: https://lore.kernel.org/platform-driver-x86/20230905185309.131295-12-brgl@bgdev.pl/


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20230909141816.58358-5-hdegoede@redhat.com
parent 1fc95b02

drivers/platform/x86/x86-android-tablets/core.c

+0 −15
Original line number Diff line number Diff line
@@ -259,7 +259,6 @@ static __init int x86_android_tablet_init(void) 
{

	const struct x86_dev_info *dev_info;

	const struct dmi_system_id *id;

	struct gpio_chip *chip;

	int i, ret = 0;



	id = dmi_first_match(x86_android_tablet_ids);
@@ -268,20 +267,6 @@ static __init int x86_android_tablet_init(void) 


	dev_info = id->driver_data;



	/*

	 * The broken DSDTs on these devices often also include broken

	 * _AEI (ACPI Event Interrupt) handlers, disable these.

	 */

	if (dev_info->invalid_aei_gpiochip) {

		chip = gpiochip_find(dev_info->invalid_aei_gpiochip,

				     gpiochip_find_match_label);

		if (!chip) {

			pr_err("error cannot find GPIO chip %s\n", dev_info->invalid_aei_gpiochip);

			return -ENODEV;

		}

		acpi_gpiochip_free_interrupts(chip);

	}



	/*

	 * Since this runs from module_init() it cannot use -EPROBE_DEFER,

	 * instead pre-load any modules which are listed as requirements.

drivers/platform/x86/x86-android-tablets/x86-android-tablets.h

+0 −1
Original line number Diff line number Diff line
@@ -66,7 +66,6 @@ struct x86_gpio_button { 
};



struct x86_dev_info {

	char *invalid_aei_gpiochip;

	const char * const *modules;

	const struct software_node *bat_swnode;

	struct gpiod_lookup_table * const *gpiod_lookup_tables;