Commit 56eb0c0e authored by Sean V Kelley's avatar Sean V Kelley Committed by Rafael J. Wysocki
Browse files

ACPI: CPPC: Fix remaining for_each_possible_cpu() to use online CPUs 



per_cpu(cpc_desc_ptr, cpu) object is initialized for only the online
CPUs via acpi_soft_cpu_online() --> __acpi_processor_start() -->
acpi_cppc_processor_probe().

However, send_pcc_cmd() and acpi_get_psd_map() still iterate over all
possible CPUs. In acpi_get_psd_map(), encountering an offline CPU
returns -EFAULT, causing cppc_cpufreq initialization to fail.

This breaks systems booted with "nosmt" or "nosmt=force".

Fix by using for_each_online_cpu() in both functions.

Fixes: 80b8286a ("ACPI / CPPC: support for batching CPPC requests")
Signed-off-by: default avatarSean V Kelley <skelley@nvidia.com>
Link: https://patch.msgid.link/20260211212254.30190-1-skelley@nvidia.com


Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent d84e1733

drivers/acpi/cppc_acpi.c

+2 −2
Original line number Diff line number Diff line
@@ -362,7 +362,7 @@ static int send_pcc_cmd(int pcc_ss_id, u16 cmd) 
end:

	if (cmd == CMD_WRITE) {

		if (unlikely(ret)) {

			for_each_possible_cpu(i) {

			for_each_online_cpu(i) {

				struct cpc_desc *desc = per_cpu(cpc_desc_ptr, i);



				if (!desc)
@@ -524,7 +524,7 @@ int acpi_get_psd_map(unsigned int cpu, struct cppc_cpudata *cpu_data) 
	else if (pdomain->coord_type == DOMAIN_COORD_TYPE_SW_ANY)

		cpu_data->shared_type = CPUFREQ_SHARED_TYPE_ANY;



	for_each_possible_cpu(i) {

	for_each_online_cpu(i) {

		if (i == cpu)

			continue;