Commit 56f16c9f authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

gpio: 74x164: use new line value setter callbacks 

struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Link: https://lore.kernel.org/r/20250303-gpiochip-set-conversion-v1-1-1d5cceeebf8b@linaro.org


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent e9316094

drivers/gpio/gpio-74x164.c

+8 −8
Original line number Diff line number Diff line
@@ -50,8 +50,8 @@ static int gen_74x164_get_value(struct gpio_chip *gc, unsigned offset) 
	return !!(chip->buffer[bank] & BIT(pin));

}



static void gen_74x164_set_value(struct gpio_chip *gc,

		unsigned offset, int val)

static int gen_74x164_set_value(struct gpio_chip *gc,

				unsigned int offset, int val)

{

	struct gen_74x164_chip *chip = gpiochip_get_data(gc);

	u8 bank = chip->registers - 1 - offset / 8;
@@ -64,10 +64,10 @@ static void gen_74x164_set_value(struct gpio_chip *gc, 
	else

		chip->buffer[bank] &= ~BIT(pin);



	__gen_74x164_write_config(chip);

	return __gen_74x164_write_config(chip);

}



static void gen_74x164_set_multiple(struct gpio_chip *gc, unsigned long *mask,

static int gen_74x164_set_multiple(struct gpio_chip *gc, unsigned long *mask,

				   unsigned long *bits)

{

	struct gen_74x164_chip *chip = gpiochip_get_data(gc);
@@ -85,7 +85,7 @@ static void gen_74x164_set_multiple(struct gpio_chip *gc, unsigned long *mask, 
		chip->buffer[bank] &= ~bankmask;

		chip->buffer[bank] |= bitmask;

	}

	__gen_74x164_write_config(chip);

	return __gen_74x164_write_config(chip);

}



static int gen_74x164_direction_output(struct gpio_chip *gc,
@@ -141,8 +141,8 @@ static int gen_74x164_probe(struct spi_device *spi) 
	chip->gpio_chip.label = spi->modalias;

	chip->gpio_chip.direction_output = gen_74x164_direction_output;

	chip->gpio_chip.get = gen_74x164_get_value;

	chip->gpio_chip.set = gen_74x164_set_value;

	chip->gpio_chip.set_multiple = gen_74x164_set_multiple;

	chip->gpio_chip.set_rv = gen_74x164_set_value;

	chip->gpio_chip.set_multiple_rv = gen_74x164_set_multiple;

	chip->gpio_chip.base = -1;

	chip->gpio_chip.ngpio = GEN_74X164_NUMBER_GPIOS * chip->registers;

	chip->gpio_chip.can_sleep = true;