Commit 57089660 authored by Francesco Dolcini's avatar Francesco Dolcini Committed by Johannes Berg
Browse files

Revert "wifi: mwifiex: Fix HT40 bandwidth issue."

This reverts commit 4fcfcbe4 ("wifi: mwifiex: Fix HT40 bandwidth
issue.")

That commit introduces a regression, when HT40 mode is enabled,
received packets are lost, this was experience with W8997 with both
SDIO-UART and SDIO-SDIO variants. From an initial investigation the
issue solves on its own after some time, but it's not clear what is
the reason. Given that this was just a performance optimization, let's
revert it till we have a better understanding of the issue and a proper
fix.

Cc: Jeff Chen <jeff.chen_1@nxp.com>
Cc: stable@vger.kernel.org
Fixes: 4fcfcbe4 ("wifi: mwifiex: Fix HT40 bandwidth issue.")
Closes: https://lore.kernel.org/all/20250603203337.GA109929@francesco-nb/


Signed-off-by: default avatarFrancesco Dolcini <francesco.dolcini@toradex.com>
Link: https://patch.msgid.link/20250605130302.55555-1-francesco@dolcini.it


[fix commit reference format]
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 2c7e4a26
Loading
Loading
Loading
Loading
+2 −4
Original line number Diff line number Diff line
@@ -403,14 +403,12 @@ mwifiex_cmd_append_11n_tlv(struct mwifiex_private *priv,

		if (sband->ht_cap.cap & IEEE80211_HT_CAP_SUP_WIDTH_20_40 &&
		    bss_desc->bcn_ht_oper->ht_param &
		    IEEE80211_HT_PARAM_CHAN_WIDTH_ANY) {
			chan_list->chan_scan_param[0].radio_type |=
				CHAN_BW_40MHZ << 2;
		    IEEE80211_HT_PARAM_CHAN_WIDTH_ANY)
			SET_SECONDARYCHAN(chan_list->chan_scan_param[0].
					  radio_type,
					  (bss_desc->bcn_ht_oper->ht_param &
					  IEEE80211_HT_PARAM_CHA_SEC_OFFSET));
		}

		*buffer += struct_size(chan_list, chan_scan_param, 1);
		ret_len += struct_size(chan_list, chan_scan_param, 1);
	}