Commit 571cc835 authored by Matthew Brost's avatar Matthew Brost
Browse files

drm/i915/selftests: Fix build after dma-fence locking rework 



The i915_active selftest no longer builds after the dma-fence locking
rework because it directly accessed the fence’s spinlock. The helper
dma_fence_spinlock() must now be used to obtain the spinlock. Update the
selftest to use dma_fence_spinlock() accordingly.

Fixes: 1f32f310 ("dma-buf: inline spinlock for fence protection v5")
Cc: Christian König <christian.koenig@amd.com>
Signed-off-by: default avatarMatthew Brost <matthew.brost@intel.com>
Reviewed-by: default avatarJonathan Cavitt <jonathan.cavitt@intel.com>
Reviewed-by: default avatarChristian König <christian.koenig@amd.com>
Link: https://patch.msgid.link/20260223172553.1663749-1-matthew.brost@intel.com
parent 196b2b95

drivers/gpu/drm/i915/selftests/i915_active.c

+2 −2
Original line number Diff line number Diff line
@@ -323,9 +323,9 @@ static void active_flush(struct i915_active *ref, 
	if (!fence)

		return;



	spin_lock_irq(fence->lock);

	spin_lock_irq(dma_fence_spinlock(fence));

	__list_del_entry(&active->cb.node);

	spin_unlock_irq(fence->lock); /* serialise with fence->cb_list */

	spin_unlock_irq(dma_fence_spinlock(fence)); /* serialise with fence->cb_list */

	atomic_dec(&ref->count);



	GEM_BUG_ON(!test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags));