Unverified Commit 572239f7 authored Jul 23, 2024 by Matthew Brost Committed by Rodrigo Vivi Sep 12, 2024

drm/xe: Remove fence check from send_tlb_invalidation



'fence' argument in send_tlb_invalidation cannot be NULL, remove
non-NULL check from send_tlb_invalidation.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202407231049.esig0Fkb-lkp@intel.com/


Fixes: 58bfe667 ("drm/xe: Drop xe_gt_tlb_invalidation_wait")
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240723190714.1744653-1-matthew.brost@intel.com


Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
(cherry picked from commit 6482253e)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

parent a2655358

drivers/gpu/drm/xe/xe_gt_tlb_invalidation.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -182,7 +182,7 @@ static int send_tlb_invalidation(struct xe_guc *guc,
		action[1] = seqno;
		ret = xe_guc_ct_send_locked(&guc->ct, action, len,
		G2H_LEN_DW_TLB_INVALIDATE, 1);
		if (!ret && fence) {
		if (!ret) {
		spin_lock_irq(&gt->tlb_invalidation.pending_lock);
		/*
		* We haven't actually published the TLB fence as per
		@@ -203,7 +203,7 @@ static int send_tlb_invalidation(struct xe_guc *guc,
		tlb_timeout_jiffies(gt));
		}
		spin_unlock_irq(&gt->tlb_invalidation.pending_lock);
		} else if (ret < 0 && fence) {
		} else if (ret < 0) {
		__invalidation_fence_signal(xe, fence);
		}
		if (!ret) {