Commit 5733d139 authored by Heiner Kallweit's avatar Heiner Kallweit Committed by Jakub Kicinski
Browse files

lan743x: remove redundant statement in lan743x_ethtool_get_eee 



eee_active is set by phy_ethtool_get_eee() already, using the same
logic plus an additional check against link speed/duplex values.
See genphy_c45_eee_is_active() for details.
So we can remove this line.

Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Link: https://lore.kernel.org/r/3340ff84-8d7a-404b-8268-732c7f281164@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 1c835c81

drivers/net/ethernet/microchip/lan743x_ethtool.c

+0 −1
Original line number Diff line number Diff line
@@ -1077,7 +1077,6 @@ static int lan743x_ethtool_get_eee(struct net_device *netdev, 
	buf = lan743x_csr_read(adapter, MAC_CR);

	if (buf & MAC_CR_EEE_EN_) {

		eee->eee_enabled = true;

		eee->eee_active = !!(eee->advertised & eee->lp_advertised);

		eee->tx_lpi_enabled = true;

		/* EEE_TX_LPI_REQ_DLY & tx_lpi_timer are same uSec unit */

		buf = lan743x_csr_read(adapter, MAC_EEE_TX_LPI_REQ_DLY_CNT);