Unverified Commit 5736aa95 authored by Harshit Mogalapalli's avatar Harshit Mogalapalli Committed by Ilpo Järvinen
Browse files

platform/x86: hp-bioscfg: move mutex_lock() down in hp_add_other_attributes() 



attr_name_kobj's memory allocation is done with mutex_lock() held, this
is not needed.

Move allocation outside of mutex_lock() so unlock is not needed when
allocation fails.

Suggested-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20231113200742.3593548-2-harshit.m.mogalapalli@oracle.com


Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent c5dbf041

drivers/platform/x86/hp/hp-bioscfg/bioscfg.c

+4 −6
Original line number Diff line number Diff line
@@ -592,13 +592,11 @@ static int hp_add_other_attributes(int attr_type) 
	int ret;

	char *attr_name;



	mutex_lock(&bioscfg_drv.mutex);



	attr_name_kobj = kzalloc(sizeof(*attr_name_kobj), GFP_KERNEL);

	if (!attr_name_kobj) {

		ret = -ENOMEM;

		goto err_other_attr_init;

	}

	if (!attr_name_kobj)

		return -ENOMEM;



	mutex_lock(&bioscfg_drv.mutex);



	/* Check if attribute type is supported */

	switch (attr_type) {